Re: Add comment explaining why queryid is int64 in pg_stat_statements

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: David Rowley <dgrowleyml(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Lukas Fittl <lukas(at)fittl(dot)com>, Shaik Mohammad Mujeeb <mujeeb(dot)sk(at)zohocorp(dot)com>, ilyaevdokimov <ilya(dot)evdokimov(at)tantorlabs(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, mujeebskdev <mujeeb(dot)sk(dot)dev(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alvaro Herrera <alvherre(at)kurilemu(dot)de>, Tomas Vondra <tomas(at)vondra(dot)me>
Subject: Re: Add comment explaining why queryid is int64 in pg_stat_statements
Date: 2025-05-29 23:34:49
Message-ID: aDjvGZXFMGMJAAHr@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, May 29, 2025 at 09:28:35AM -0500, Nathan Bossart wrote:
> On Thu, May 29, 2025 at 01:53:07PM +0900, Michael Paquier wrote:
>> Now, I don't really want to take a leap of faith without the RMT being
>> OK with that now that we are in beta1.
>
> After reading through this thread and the latest patch set, I don't see any
> strong reason for the RMT to object to this change for v18. IIUC some
> extensions may need to adapt, but we're still a few months from 18.0, so
> that seems okay. I vaguely recall that we've made other small
> extension-breaking changes during the beta period for previous major
> releases.

Thanks, Nathan. Let's proceed with the change then. David, would you
prefer handling the patch you have written by yourself for the query
ID part?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2025-05-29 23:51:02 Re: Add comment explaining why queryid is int64 in pg_stat_statements
Previous Message Bruce Momjian 2025-05-29 23:32:01 Re: pg18: Virtual generated columns are not (yet) safe when superuser selects from them