| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | David Rowley <dgrowleyml(at)gmail(dot)com>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Lukas Fittl <lukas(at)fittl(dot)com>, Shaik Mohammad Mujeeb <mujeeb(dot)sk(at)zohocorp(dot)com>, ilyaevdokimov <ilya(dot)evdokimov(at)tantorlabs(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, mujeebskdev <mujeeb(dot)sk(dot)dev(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alvaro Herrera <alvherre(at)kurilemu(dot)de>, Tomas Vondra <tomas(at)vondra(dot)me> |
| Subject: | Re: Add comment explaining why queryid is int64 in pg_stat_statements |
| Date: | 2025-05-29 14:28:35 |
| Message-ID: | aDhvEzWlRl3sWEt4@nathan |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 29, 2025 at 01:53:07PM +0900, Michael Paquier wrote:
> On Thu, May 22, 2025 at 01:01:14PM +0900, Michael Paquier wrote:
>> I have added an open item about the plan ID part as it applies to v18,
>> adding the RMT in CC to get an opinion. If we cannot get a consensus
>> on all that, letting things as they are is still logically correct,
>> even with the -Wwarnings-format-signedness argument which is not
>> included by default currently.
>>
>> Has somebody an opinion to offer?
>
> It has been one week since this last update, and there has been
> nothing except the sound of cicadas. IMO, I think that we should just
> pull the switch and make both of these IDs signed on HEAD, taking case
> of the potential signedness warning issues.
>
> Now, I don't really want to take a leap of faith without the RMT being
> OK with that now that we are in beta1.
After reading through this thread and the latest patch set, I don't see any
strong reason for the RMT to object to this change for v18. IIUC some
extensions may need to adapt, but we're still a few months from 18.0, so
that seems okay. I vaguely recall that we've made other small
extension-breaking changes during the beta period for previous major
releases.
--
nathan
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Greg Sabino Mullane | 2025-05-29 14:32:57 | POC: Carefully exposing information without authentication |
| Previous Message | Robert Haas | 2025-05-29 13:58:31 | Re: autoprewarm_dump_now |