| From: | Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> |
|---|---|
| To: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Jelte Fennema-Nio <postgres(at)jeltef(dot)nl> |
| Subject: | Re: pgsql: Make cancel request keys longer |
| Date: | 2025-05-23 21:59:44 |
| Message-ID: | CAOYmi+nmqLB9jYPy0PNmTbLbzrAEfwrGVeKe4G_S4fRs4-D52w@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Thu, May 8, 2025 at 11:38 PM Heikki Linnakangas <hlinnaka(at)iki(dot)fi> wrote:
> It didn't occur to me that you could write it simply as 'msgLength - 4'.
> That depends on knowing that the preceding fields are exactly 4 bytes
> long, but that's clear enough if we just add a comment on that, see
> attached.
Sorry for the conference delay; this looks fine to me.
One of the side effects of the uint8 change is that the client now
accepts cancel keys up to roughly 30kb. Is that intended?
--Jacob
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chris Gooch | 2025-05-24 10:01:05 | Re: [EXT] Re: GSS Auth issue when user member of lots of AD groups |
| Previous Message | Bruce Momjian | 2025-05-23 21:02:35 | pgsql: doc PG 18 relnotes: clarify btree skip-scan item |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2025-05-24 00:09:36 | Re: Addition of %b/backend_type in log_line_prefix of TAP test logs |
| Previous Message | Mihail Nikalayeu | 2025-05-23 21:59:00 | Re: Revisiting {CREATE INDEX, REINDEX} CONCURRENTLY improvements |