| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Jacob Champion <pchampion(at)vmware(dot)com>, "daniel(at)yesql(dot)se" <daniel(at)yesql(dot)se>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "michael(at)paquier(dot)xyz" <michael(at)paquier(dot)xyz> |
| Subject: | Re: Preventing abort() and exit() calls in libpq |
| Date: | 2021-07-01 19:03:58 |
| Message-ID: | a6c5b570-a7b7-bd0b-59e7-33af54f51dbe@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 01.07.21 20:14, Tom Lane wrote:
> The variant of this I'd been thinking of was
>
> $(shlib): $(OBJS) | $(SHLIB_PREREQS)
> $(LINK.shared) -o $@ $(OBJS) $(LDFLAGS) $(LDFLAGS_SL) $(SHLIB_LINK)
> +ifneq (,$(SHLIB_EXTRA_ACTION))
> + $(SHLIB_EXTRA_ACTION)
> +endif
>
> (and similarly in several other places); then libpq's Makefile
> could set SHLIB_EXTRA_ACTION to the desired thing.
Right, that looks sensible. (Maybe the ifneq isn't actually necessary,
since if the variable is not set, nothing would happen.)
> The problem then is, what happens when the extra action fails?
> Without .DELETE_ON_ERROR, the shlib is still there and the next
> make run will think everything's good.
Right. .DELETE_ON_ERROR is already set in Makefile.global, so it's not
necessary to set it again.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-07-01 19:10:05 | Re: Preventing abort() and exit() calls in libpq |
| Previous Message | Tom Lane | 2021-07-01 18:41:09 | Re: rand48 replacement |