| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | Jacob Champion <pchampion(at)vmware(dot)com>, "daniel(at)yesql(dot)se" <daniel(at)yesql(dot)se>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, "michael(at)paquier(dot)xyz" <michael(at)paquier(dot)xyz> |
| Subject: | Re: Preventing abort() and exit() calls in libpq |
| Date: | 2021-07-01 18:14:24 |
| Message-ID: | 745046.1625163264@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
> On 01.07.21 00:41, Jacob Champion wrote:
>> Spitballing -- if you don't like the stamp file, you could add the
>> check to the end of the $(shlib) rule, surrounded by an ifeq check.
>> Then .DELETE_ON_ERROR should take care of the rest, I think.
> Somewhere in the $(shlib) rule would seem most appropriate. But I don't
> understand the rest: What ifeq, and why .DELETE_ON_ERROR?
The variant of this I'd been thinking of was
$(shlib): $(OBJS) | $(SHLIB_PREREQS)
$(LINK.shared) -o $@ $(OBJS) $(LDFLAGS) $(LDFLAGS_SL) $(SHLIB_LINK)
+ifneq (,$(SHLIB_EXTRA_ACTION))
+ $(SHLIB_EXTRA_ACTION)
+endif
(and similarly in several other places); then libpq's Makefile
could set SHLIB_EXTRA_ACTION to the desired thing.
The problem then is, what happens when the extra action fails?
Without .DELETE_ON_ERROR, the shlib is still there and the next
make run will think everything's good.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2021-07-01 18:21:04 | Re: Preventing abort() and exit() calls in libpq |
| Previous Message | Peter Eisentraut | 2021-07-01 18:05:59 | Re: Preventing abort() and exit() calls in libpq |