|From:||Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>|
|To:||Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>|
|Cc:||Aleksander Alekseev <aleksander(at)timescale(dot)com>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>|
|Subject:||Re: rand48 replacement|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr> writes:
>> Although this patch is marked RFC, the cfbot shows it doesn't
>> even compile on Windows. I think you missed updating Mkvcbuild.pm.
> Indeed. Here is a blind attempt at fixing the build, I'll check later to
> see whether it works. It would help me if the cfbot results were
> integrated into the cf app.
Hmm, not there yet per cfbot, not sure why not.
Anyway, after taking a very quick look at the patch itself, I've
got just one main objection: I don't approve of putting this in
port.h or src/port/. erand48.c is there because we envisioned it
originally as an occasionally-used substitute for libc facilities.
But this is most certainly not that, so it belongs in src/common/
instead. I'd also be inclined to invent a new single-purpose .h
file for it.
I see that you probably did that because random.c and srandom.c
depend on it, but I wonder why we don't make an effort to flush
those altogether. It's surely pretty confusing to newbies that
what appears to be a call of the libc primitives is no such thing.
regards, tom lane
|Next Message||Peter Eisentraut||2021-07-01 19:03:58||Re: Preventing abort() and exit() calls in libpq|
|Previous Message||Jacob Champion||2021-07-01 18:21:04||Re: Preventing abort() and exit() calls in libpq|