| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: commented out code |
| Date: | 2026-01-22 11:56:25 |
| Message-ID: | a690f6d3-c53e-41cf-8a26-756b1ef16442@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 20.01.26 19:55, Tom Lane wrote:
> Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
>> On 05.12.25 17:38, Heikki Linnakangas wrote:
>>> #if 0
>>> Oid subtype = PG_GETARG_OID(3);
>>> #endif
>>>
>>> is yet another option. It keeps the indentation, although you won't get
>>> the compiler checking.
>
>> After some reflection, I like this approach. It keeps the indentation
>> and enables syntax highlighting, so it makes some of these blocks much
>> easier to read.
>
> I think "#ifdef NOT_USED" is our more common style. +1 other than
> that nitpick.
Ok, committed like that.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Henson Choi | 2026-01-22 11:56:30 | Re: SQL Property Graph Queries (SQL/PGQ) |
| Previous Message | shveta malik | 2026-01-22 11:37:31 | Re: Assert the timestamp is available for ORIGN_DIFFERS conflicts |