| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
| Cc: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: commented out code |
| Date: | 2026-01-20 18:55:31 |
| Message-ID: | 1711916.1768935331@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
> On 05.12.25 17:38, Heikki Linnakangas wrote:
>> #if 0
>> Oid subtype = PG_GETARG_OID(3);
>> #endif
>>
>> is yet another option. It keeps the indentation, although you won't get
>> the compiler checking.
> After some reflection, I like this approach. It keeps the indentation
> and enables syntax highlighting, so it makes some of these blocks much
> easier to read.
I think "#ifdef NOT_USED" is our more common style. +1 other than
that nitpick.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2026-01-20 19:03:45 | Re: Add missing JIT inline pass for llvm>=17 |
| Previous Message | Tom Lane | 2026-01-20 18:52:08 | Re: Undefined behavior detected by new clang's ubsan |