Re: DROP SUBSCRIPTION, query cancellations and slot handling

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Petr Jelinek <petr(dot)jelinek(at)2ndquadrant(dot)com>
Cc: PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: DROP SUBSCRIPTION, query cancellations and slot handling
Date: 2017-04-21 12:49:40
Message-ID: a621b94c-aeab-4432-330f-cc20256c5b89@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 4/20/17 22:57, Michael Paquier wrote:
> On Fri, Apr 21, 2017 at 11:34 AM, Petr Jelinek
> <petr(dot)jelinek(at)2ndquadrant(dot)com> wrote:
>> On 20/04/17 23:30, Peter Eisentraut wrote:
>>> On 4/20/17 10:19, Petr Jelinek wrote:
>>>> Hmm well since this only affects the synchronization of table
>>>> states/names, I guess we could just simply do that before we create the
>>>> slot as there is no expectancy of consistency between slot and the table
>>>> list snapshot.
>>>
>>> I suppose that wouldn't hurt.
>>>
>>> Prior to the table sync patch, a missing target relation would just show
>>> up as an error later on in the logs. So having the error sooner
>>> actually seems like a good change.
>>>
>>
>> Very simple patch to make.
>
> +1 for that.

Committed that.

I don't think there is anything else open here.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2017-04-21 13:02:32 Re: On-disk format of SCRAM verifiers
Previous Message Jesper Pedersen 2017-04-21 12:46:15 Re: dtrace probes