| From: | Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: dtrace probes |
| Date: | 2017-04-21 12:46:15 |
| Message-ID: | 8b892d27-fe7b-71e8-212b-b5bffb2f073f@redhat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 04/20/2017 10:30 AM, Jesper Pedersen wrote:
>> I think this fix is harmless and has some value in terms of
>> consistency. One minor suggestion is that you should leave a space
>> after typecasting.
>>
>> - TRACE_POSTGRESQL_LWLOCK_WAIT_DONE(T_NAME(lock), mode);
>> + TRACE_POSTGRESQL_LWLOCK_WAIT_DONE(T_NAME(lock), (int)mode);
>>
>> There should be a space like "(int) mode".
>>
>>
>
> v2 attached.
>
I managed to attach the same patch again, so here is v3.
Best regards,
Jesper
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Explicit-cast-LWLockMode-which-an-enum-to-int-in-ord_v3.pacth | text/plain | 3.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2017-04-21 12:49:40 | Re: DROP SUBSCRIPTION, query cancellations and slot handling |
| Previous Message | Stephen Frost | 2017-04-21 12:25:42 | Re: On-disk format of SCRAM verifiers |