| From: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
|---|---|
| To: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | Jaime Casanova <jaime(dot)casanova(at)2ndquadrant(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Partitioned tables and covering indexes |
| Date: | 2018-04-10 15:36:00 |
| Message-ID: | a5ca67cf-0448-7875-ae89-64495748c016@sigaev.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> Does the attached fix look correct? Haven't checked the fix with ATTACH
> PARTITION though.
>
>
> Attached patch seems to fix the problem. However, I would rather get
> rid of modifying stmt->indexParams. That seems to be more logical
> for me. Also, it would be good to check some covering indexes on
> partitioned tables. See the attached patch.
Seems right way, do not modify incoming object and do not copy rather large and
deep nested structure as suggested by Amit.
But it will be better to have a ATTACH PARTITION test too.
--
Teodor Sigaev E-mail: teodor(at)sigaev(dot)ru
WWW: http://www.sigaev.ru/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Anthony Iliopoulos | 2018-04-10 15:40:05 | Re: PostgreSQL's handling of fsync() errors is unsafe and risks data loss at least on XFS |
| Previous Message | Tom Lane | 2018-04-10 15:34:17 | Re: Boolean partitions syntax |