| From: | Jaime Casanova <jaime(dot)casanova(at)2ndquadrant(dot)com> |
|---|---|
| To: | Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Cc: | Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Partitioned tables and covering indexes |
| Date: | 2018-04-10 20:49:11 |
| Message-ID: | CAJGNTeM=XO2eve+YFdwS5ag+zQi6mHa5d-iKNLtNVZcMwvThcQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10 April 2018 at 10:36, Teodor Sigaev <teodor(at)sigaev(dot)ru> wrote:
>> Does the attached fix look correct? Haven't checked the fix with
>> ATTACH
>> PARTITION though.
>>
>>
>> Attached patch seems to fix the problem. However, I would rather get
>> rid of modifying stmt->indexParams. That seems to be more logical
>> for me. Also, it would be good to check some covering indexes on
>> partitioned tables. See the attached patch.
>
> Seems right way, do not modify incoming object and do not copy rather large
> and deep nested structure as suggested by Amit.
>
> But it will be better to have a ATTACH PARTITION test too.
>
the patch worked for me, i also tried some combinations using ATTACH
PARTITION and found no problems
--
Jaime Casanova www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Joshua D. Drake | 2018-04-10 20:57:34 | Re: PostgreSQL's handling of fsync() errors is unsafe and risks data loss at least on XFS |
| Previous Message | Peter Geoghegan | 2018-04-10 20:37:50 | Re: WIP: Covering + unique indexes. |