Re: Incorrect comment in get_partition_dispatch_recurse

From: Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>
To: David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Incorrect comment in get_partition_dispatch_recurse
Date: 2018-05-18 01:56:55
Message-ID: a2d585af-b6a7-4b96-c360-7ef0fba6eba4@lab.ntt.co.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2018/05/18 5:56, David Rowley wrote:
> On 18 May 2018 at 06:21, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> All right, so let's just say that explicitly. Maybe something like
>> the attached.
>
> That looks fine to me.

Me too, except:

+ * *pds list is the root partition, so 0 always means the first leaf. When

I prefer "root partitioned table" over "root partition", and git grep
suggests that that's actually what we use elsewhere in the source code.

Thanks,
Amit

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2018-05-18 02:30:05 Re: Transform for pl/perl
Previous Message Michael Paquier 2018-05-18 01:46:46 Re: SCRAM with channel binding downgrade attack