| From: | Robert Haas <robertmhaas(at)gmail(dot)com> |
|---|---|
| To: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Incorrect comment in get_partition_dispatch_recurse |
| Date: | 2018-05-18 20:13:20 |
| Message-ID: | CA+TgmoZEAz1Mic1SUDcjNhy+RxOisKRcyPaJopQcvWdK6MqDug@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 17, 2018 at 9:56 PM, Amit Langote
<Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> wrote:
> On 2018/05/18 5:56, David Rowley wrote:
>> On 18 May 2018 at 06:21, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>>> All right, so let's just say that explicitly. Maybe something like
>>> the attached.
>>
>> That looks fine to me.
>
> Me too, except:
>
> + * *pds list is the root partition, so 0 always means the first leaf. When
>
> I prefer "root partitioned table" over "root partition", and git grep
> suggests that that's actually what we use elsewhere in the source code.
I don't know that it's necessary to be that rigid about this, so I
chose to commit without changing it.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2018-05-18 20:25:22 | Re: Incorrect comment in get_partition_dispatch_recurse |
| Previous Message | Robert Haas | 2018-05-18 20:05:32 | Re: Built-in connection pooling |