Re: Add isCatalogRel in rmgrdesc

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Add isCatalogRel in rmgrdesc
Date: 2023-12-12 09:15:01
Message-ID: ZXgklSDHCr6l5coG@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Dec 12, 2023 at 09:23:46AM +0100, Drouvot, Bertrand wrote:
> Please find attached a patch to add this field in the related rmgrdesc (i.e
> all the ones that already provide the snapshotConflictHorizon except the one
> related to xl_heap_visible: indeed a new bit was added in its flag field in 6af1793954
> instead of adding the isCatalogRel bool).
>
> I think it's worth it, as this new field could help diagnose conflicts issues (if any).

Agreed that this is helpful. One would likely guess if you are
dealing with a catalog relation depending on its relfilenode, but that
does not take into account user_catalog_table that can be set as a
reloption, impacting the value of isCatalogRel stored in the records.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Drouvot, Bertrand 2023-12-12 09:41:22 Re: Add isCatalogRel in rmgrdesc
Previous Message shveta malik 2023-12-12 09:14:28 Re: Synchronizing slots from primary to standby