Add isCatalogRel in rmgrdesc

From: "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>
To: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Add isCatalogRel in rmgrdesc
Date: 2023-12-12 08:23:46
Message-ID: 957dc8f9-2a02-4640-9c01-9dcbf97c4187@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi hackers,

6af1793954 added a new field namely "isCatalogRel" in some WAL records
to help detecting row removal conflict during logical decoding from standby.

Please find attached a patch to add this field in the related rmgrdesc (i.e
all the ones that already provide the snapshotConflictHorizon except the one
related to xl_heap_visible: indeed a new bit was added in its flag field in 6af1793954
instead of adding the isCatalogRel bool).

I think it's worth it, as this new field could help diagnose conflicts issues (if any).

Looking forward to your feedback,

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Attachment Content-Type Size
v1-0001-adding-isCatalogRel-to-rmgrdesc.patch text/plain 5.9 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nicolas Lutic 2023-12-12 08:40:14 planner chooses incremental but not the best one
Previous Message John Naylor 2023-12-12 05:22:38 Re: Change GUC hashtable to use simplehash?