Re: Add isCatalogRel in rmgrdesc

Hi,

On 12/12/23 10:15 AM, Michael Paquier wrote:
> On Tue, Dec 12, 2023 at 09:23:46AM +0100, Drouvot, Bertrand wrote:
>> Please find attached a patch to add this field in the related rmgrdesc (i.e
>> all the ones that already provide the snapshotConflictHorizon except the one
>> related to xl_heap_visible: indeed a new bit was added in its flag field in 6af1793954
>> instead of adding the isCatalogRel bool).
>>
>> I think it's worth it, as this new field could help diagnose conflicts issues (if any).
>
> Agreed that this is helpful.

Thanks for looking at it!

> One would likely guess if you are
> dealing with a catalog relation depending on its relfilenode, but that
> does not take into account user_catalog_table that can be set as a
> reloption, impacting the value of isCatalogRel stored in the records.

Exactly and not mentioning the other checks in RelationIsAccessibleInLogicalDecoding()
like the wal_level >= logical one.

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com