| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Alexander Korotkov <akorotkov(at)postgresql(dot)org> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Teach contrib/amcheck to check the unique constraint violation |
| Date: | 2023-10-30 07:17:52 |
| Message-ID: | ZT9YoDPEQBUMrIHg@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Hi Alexander,
On Fri, Oct 27, 2023 at 09:21:50PM +0000, Alexander Korotkov wrote:
> Teach contrib/amcheck to check the unique constraint violation
>
> Add the 'checkunique' argument to bt_index_check() and bt_index_parent_check().
> When the flag is specified the procedures will check the unique constraint
> violation for unique indexes. Only one heap entry for all equal keys in
> the index should be visible (including posting list entries). Report an error
> otherwise.
>
> pg_amcheck called with the --checkunique option will do the same check for all
> the indexes it checks.
koel is unhappy with the indentation done in this commit. See the
parts about verify_nbtree.c and pg_amcheck.c:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=koel&dt=2023-10-30%2007%3A04%3A04
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-10-30 08:19:37 | pgsql: Expand regression tests for pg_stat_reset_shared() |
| Previous Message | Michael Paquier | 2023-10-30 07:15:43 | Re: pgsql: doc: comment wording improvement |