Re: pgsql: Teach contrib/amcheck to check the unique constraint violation

On Mon, Oct 30, 2023 at 9:18 AM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Fri, Oct 27, 2023 at 09:21:50PM +0000, Alexander Korotkov wrote:
> > Teach contrib/amcheck to check the unique constraint violation
> >
> > Add the 'checkunique' argument to bt_index_check() and bt_index_parent_check().
> > When the flag is specified the procedures will check the unique constraint
> > violation for unique indexes. Only one heap entry for all equal keys in
> > the index should be visible (including posting list entries). Report an error
> > otherwise.
> >
> > pg_amcheck called with the --checkunique option will do the same check for all
> > the indexes it checks.
>
> koel is unhappy with the indentation done in this commit. See the
> parts about verify_nbtree.c and pg_amcheck.c:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=koel&dt=2023-10-30%2007%3A04%3A04

Fixed, thank you for catching it!

------
Regards,
Alexander Korotkov