Re: pgsql: Teach contrib/amcheck to check the unique constraint violation

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Alexander Korotkov <akorotkov(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Teach contrib/amcheck to check the unique constraint violation
Date: 2023-10-30 18:52:55
Message-ID: ZT_7hyCRfhkAFI0b@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Mon, Oct 30, 2023 at 04:17:52PM +0900, Michael Paquier wrote:
> Hi Alexander,
>
> On Fri, Oct 27, 2023 at 09:21:50PM +0000, Alexander Korotkov wrote:
> > Teach contrib/amcheck to check the unique constraint violation
> >
> > Add the 'checkunique' argument to bt_index_check() and bt_index_parent_check().
> > When the flag is specified the procedures will check the unique constraint
> > violation for unique indexes. Only one heap entry for all equal keys in
> > the index should be visible (including posting list entries). Report an error
> > otherwise.
> >
> > pg_amcheck called with the --checkunique option will do the same check for all
> > the indexes it checks.
>
> koel is unhappy with the indentation done in this commit. See the
> parts about verify_nbtree.c and pg_amcheck.c:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=koel&dt=2023-10-30%2007%3A04%3A04

Thanks, ran pgindent fix commits de64268561 and 5ae2087202a.

--
Bruce Momjian <bruce(at)momjian(dot)us> https://momjian.us
EDB https://enterprisedb.com

Only you can decide what is important to you.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2023-10-30 18:53:00 pgsql: pgindent run to fix commits de64268561 and 5ae2087202a
Previous Message Peter Eisentraut 2023-10-30 10:24:56 pgsql: Fill in more of ObjectProperty