| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, gkokolatos(at)pm(dot)me, shiy(dot)fnst(at)fujitsu(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org, Rachel Heaton <rachelmheaton(at)gmail(dot)com> |
| Subject: | Re: Add LZ4 compression in pg_dump |
| Date: | 2023-04-13 00:53:53 |
| Message-ID: | ZDdSoaE/30dS+Fxr@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Apr 13, 2023 at 09:37:06AM +0900, Michael Paquier wrote:
> > If you don't insist on calling parse(NONE), the only change is to remove
> > the empty #else, which was my original patch.
>
> Removing the empty else has as problem to create an empty if block,
> which could be itself a cause of warnings?
I doubt it - in the !HAVE_LIBZ case, it's currently an "if" statement
with nothing but a comment, which isn't a problem.
I think the only issue with an empty "if" is when you have no braces,
like:
if (...)
#if ...
something;
#endif
// problem here //
--
Justin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2023-04-13 01:24:00 | Re: Clean up hba.c of code freeing regexps |
| Previous Message | Thomas Munro | 2023-04-13 00:53:51 | Re: Clean up hba.c of code freeing regexps |