From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
Cc: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, gkokolatos(at)pm(dot)me, shiy(dot)fnst(at)fujitsu(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org, Rachel Heaton <rachelmheaton(at)gmail(dot)com> |
Subject: | Re: Add LZ4 compression in pg_dump |
Date: | 2023-04-25 06:02:18 |
Message-ID: | ZEds6kwbPUdwsKh8@paquier.xyz |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Apr 12, 2023 at 07:53:53PM -0500, Justin Pryzby wrote:
> I doubt it - in the !HAVE_LIBZ case, it's currently an "if" statement
> with nothing but a comment, which isn't a problem.
>
> I think the only issue with an empty "if" is when you have no braces,
> like:
>
> if (...)
> #if ...
> something;
> #endif
>
> // problem here //
(My apologies for the late reply.)
Still it could be easily messed up, and that's not a style that
really exists in the tree, either, because there are always #else
blocks set up in such cases. Another part that makes me a bit
uncomfortable is that we would still call twice
parse_compress_specification(), something that should not happen but
we are doing so on HEAD because the default compression_algorithm_str
is "none" and we want to enforce "gzip" for custom and directory
formats when building with zlib.
What about just moving this block a bit up, just before the
compression spec parsing, then? If we set compression_algorithm_str,
the specification is compiled with the expected default, once instead
of twice.
--
Michael
Attachment | Content-Type | Size |
---|---|---|
pgdump-comment-3.patch | text/x-diff | 1.4 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2023-04-25 06:18:44 | Re: Move un-parenthesized syntax docs to "compatibility" for few SQL commands |
Previous Message | Michael Paquier | 2023-04-25 05:17:58 | Re: ALTER TABLE SET ACCESS METHOD on partitioned tables |