From: | Stephen Frost <sfrost(at)snowman(dot)net> |
---|---|
To: | "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
Subject: | Re: longfin missing gssapi_ext.h |
Date: | 2023-04-12 14:47:58 |
Message-ID: | ZDbEnh7KMx9xBG2a@tamriel.snowman.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Greetings,
* Jonathan S. Katz (jkatz(at)postgresql(dot)org) wrote:
> On 4/12/23 10:33 AM, Stephen Frost wrote:
> > * Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
> > > Stephen Frost <sfrost(at)snowman(dot)net> writes:
> > > > Understood. Please find attached the updated patch with changes to the
> > > > commit message to indicate that we now require MIT Kerberos, an
> > > > additional explicit check for gssapi_ext.h in configure.ac/configure,
> > > > along with updated documentation explicitly saying we require MIT
> > > > Kerberos for GSSAPI support.
> > >
> > > Um ... could you package this as a straight un-revert of the
> > > previous commit, then a delta patch? Would be easier to review.
> >
> > Sure, reworked that way and attached.
>
> Docs read well. A few questions/commenets:
>
> * On [1] -- do we want to add a note that it's not just Kerberos, but MIT
> Kerberos?
Yes, makes sense, updated.
> * On [2] -- we mention "kadmin tool of MIT-compatible Kerberos 5" which is
> AIUI is still technically correct, but do we want to drop the "-compatible?"
> (precedent in [3])
Yup, cleaned that up also.
Updated patch set attached.
Thanks!
Stephen
Attachment | Content-Type | Size |
---|---|---|
0001-Revert-Revert-Add-support-for-Kerberos-credential-de.patch | text/x-diff | 74.0 KB |
0002-Explicitly-require-MIT-Kerberos-for-GSSAPI.patch | text/x-diff | 6.0 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Jonathan S. Katz | 2023-04-12 14:54:53 | Re: longfin missing gssapi_ext.h |
Previous Message | Daniel Gustafsson | 2023-04-12 14:45:33 | Re: longfin missing gssapi_ext.h |