Re: longfin missing gssapi_ext.h

From: "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>
To: Stephen Frost <sfrost(at)snowman(dot)net>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Subject: Re: longfin missing gssapi_ext.h
Date: 2023-04-12 14:40:53
Message-ID: bcca89d6-9c87-1a92-60dc-229edc758a79@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 4/12/23 10:33 AM, Stephen Frost wrote:
> Greetings,
>
> * Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
>> Stephen Frost <sfrost(at)snowman(dot)net> writes:
>>> Understood. Please find attached the updated patch with changes to the
>>> commit message to indicate that we now require MIT Kerberos, an
>>> additional explicit check for gssapi_ext.h in configure.ac/configure,
>>> along with updated documentation explicitly saying we require MIT
>>> Kerberos for GSSAPI support.
>>
>> Um ... could you package this as a straight un-revert of the
>> previous commit, then a delta patch? Would be easier to review.
>
> Sure, reworked that way and attached.

Docs read well. A few questions/commenets:

* On [1] -- do we want to add a note that it's not just Kerberos, but
MIT Kerberos?

* On [2] -- we mention "kadmin tool of MIT-compatible Kerberos 5" which
is AIUI is still technically correct, but do we want to drop the
"-compatible?" (precedent in [3])

Thanks,

Jonathan

[1] https://www.postgresql.org/docs/devel/install-requirements.html
[2] https://www.postgresql.org/docs/devel/gssapi-auth.html
[3] https://www.postgresql.org/docs/devel/regress-run.html

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Daniel Gustafsson 2023-04-12 14:45:33 Re: longfin missing gssapi_ext.h
Previous Message David Gilman 2023-04-12 14:40:28 Note new NULLS NOT DISTINCT on unique index tutorial page