Re: longfin missing gssapi_ext.h

On 4/12/23 10:47 AM, Stephen Frost wrote:
> Greetings,
>
> * Jonathan S. Katz (jkatz(at)postgresql(dot)org) wrote:
>> On 4/12/23 10:33 AM, Stephen Frost wrote:
>>> * Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
>>>> Stephen Frost <sfrost(at)snowman(dot)net> writes:
>>>>> Understood. Please find attached the updated patch with changes to the
>>>>> commit message to indicate that we now require MIT Kerberos, an
>>>>> additional explicit check for gssapi_ext.h in configure.ac/configure,
>>>>> along with updated documentation explicitly saying we require MIT
>>>>> Kerberos for GSSAPI support.
>>>>
>>>> Um ... could you package this as a straight un-revert of the
>>>> previous commit, then a delta patch? Would be easier to review.
>>>
>>> Sure, reworked that way and attached.
>>
>> Docs read well. A few questions/commenets:
>>
>> * On [1] -- do we want to add a note that it's not just Kerberos, but MIT
>> Kerberos?
>
> Yes, makes sense, updated.
>
>> * On [2] -- we mention "kadmin tool of MIT-compatible Kerberos 5" which is
>> AIUI is still technically correct, but do we want to drop the "-compatible?"
>> (precedent in [3])
>
> Yup, cleaned that up also.
>
> Updated patch set attached.

Thanks! I'll sign off on the docs portion.

The meson build code looks good to me (I just compared it to what
already exists). Similar comment to the autoconf code.

Thanks,

Jonathan