| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~ |
| Date: | 2022-09-12 00:08:50 |
| Message-ID: | Yx54ksc+zBkm2Uoi@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Sep 12, 2022 at 09:42:25AM +1200, Thomas Munro wrote:
> When looking the function up it made sense to use the name ending in
> '...A', but when calling directly I think we shouldn't use the A
> suffix, we should let the <winldap.h> macros do that for us[1]. (I
> wondered for a moment if that would even make Windows and Unix code
> the same, but sadly not due to the extra NULL arguments.)
Good idea, I did not noticed this part. This should work equally, so
done this way and applied. I am keeping an eye on the buildfarm.
--
Michael
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2022-09-12 00:54:43 | Re: Background writer and checkpointer in crash recovery |
| Previous Message | Thomas Munro | 2022-09-11 22:44:38 | Re: pg15b4: FailedAssertion("TransactionIdIsValid(xmax) |