| From: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Justin Pryzby <pryzby(at)telsasoft(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Juan José Santamaría Flecha <juanjo(dot)santamaria(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Bump MIN_WINNT to 0x0600 (Vista) as minimal runtime in 16~ |
| Date: | 2022-09-11 21:42:25 |
| Message-ID: | CA+hUKG+oFsGCN3HkG_-_U9fKqpQkL48RZ-0AKg7H5biLnXC76A@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sun, Sep 11, 2022 at 12:29 PM Michael Paquier <michael(at)paquier(dot)xyz> wrote:
> On Fri, Sep 09, 2022 at 08:11:09PM +0900, Michael Paquier wrote:
> > Based on what I can see, the Windows animals seem to have digested
> > 47bd0b3 (cygwin, MinGW and MSVC), so I think that we are good.
Great, that's a lot of nice cleanup.
> The last part that's worth adjusting is ldap_start_tls_sA(), which
> would lead to the attached simplification.
- if ((r = _ldap_start_tls_sA(*ldap, NULL, NULL, NULL, NULL))
!= LDAP_SUCCESS)
+ if ((r = ldap_start_tls_sA(*ldap, NULL, NULL, NULL, NULL)) !=
LDAP_SUCCESS)
When looking the function up it made sense to use the name ending in
'...A', but when calling directly I think we shouldn't use the A
suffix, we should let the <winldap.h> macros do that for us[1]. (I
wondered for a moment if that would even make Windows and Unix code
the same, but sadly not due to the extra NULL arguments.)
[1] https://docs.microsoft.com/en-us/windows/win32/api/winldap/nf-winldap-ldap_start_tls_sa
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-09-11 22:31:41 | Re: Splitting up guc.c |
| Previous Message | Robert Treat | 2022-09-11 20:35:13 | Re: New docs chapter on Transaction Management and related changes |