| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Add suport for server-side LZ4 base backup compression. |
| Date: | 2022-02-13 03:28:31 |
| Message-ID: | Ygh63xlK4p+mFB8T@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Sat, Feb 12, 2022 at 05:16:03PM -0500, Tom Lane wrote:
> It looks to me like somebody figured it didn't need any more support
> than gzip/bzip2, which is wrong on a couple of grounds:
> * hardly any modern platforms lack those, unlike lz4
> * we don't invoke either one of them during testing, only when
> you explicitly ask to make a compressed tarball
>
> I think adding an explicit PGAC_PATH_PROGS would be worth the cycles.
Well, this somebody is I, and the buildfarm did not blow up on any of
that so that looked rather fine. Adding a few cycles for this check
is fine by me. What do you think of the attached?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| lz4-configure.patch | text/x-diff | 3.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-02-13 03:43:18 | pgsql: ci: fix copy-paste mistake in 16eb8231d1b. |
| Previous Message | Andres Freund | 2022-02-13 00:24:20 | pgsql: ci: macos: align sysinfo_script to other tasks. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2022-02-13 03:36:13 | Re: [PoC] Improve dead tuple storage for lazy vacuum |
| Previous Message | Justin Pryzby | 2022-02-13 02:47:04 | Re: Adding CI to our tree |