Re: pgsql: Add suport for server-side LZ4 base backup compression.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Add suport for server-side LZ4 base backup compression.
Date: 2022-02-13 04:12:50
Message-ID: 2523849.1644725570@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Sat, Feb 12, 2022 at 05:16:03PM -0500, Tom Lane wrote:
>> I think adding an explicit PGAC_PATH_PROGS would be worth the cycles.

> Well, this somebody is I, and the buildfarm did not blow up on any of
> that so that looked rather fine.

Eh? copperhead for one is failing for exactly this reason:

Bailout called. Further testing stopped: failed to execute command "lz4 -d -m /home/pgbf/buildroot/HEAD/pgsql.build/src/bin/pg_verifybackup/tmp_check/t_008_untar_primary_data/backup/server-backup/base.tar.lz4": No such file or directory

> Adding a few cycles for this check
> is fine by me. What do you think of the attached?

Looks OK as far as it goes ... but do we need anything on the
MSVC side?

Also, I can't help wondering why we have both GZIP_PROGRAM and GZIP
variables. I suppose that's a separate issue though.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Christoph Berg 2022-02-13 11:51:10 Re: pgsql: pg_upgrade: Preserve relfilenodes and tablespace OIDs.
Previous Message Andres Freund 2022-02-13 03:43:18 pgsql: ci: fix copy-paste mistake in 16eb8231d1b.

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2022-02-13 04:42:38 Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints
Previous Message Andres Freund 2022-02-13 04:12:42 Re: Rewriting the test of pg_upgrade as a TAP test - take three - remastered set