| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgsql: Add suport for server-side LZ4 base backup compression. |
| Date: | 2022-02-12 22:16:03 |
| Message-ID: | 2460218.1644704163@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Sat, Feb 12, 2022 at 5:09 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
>> I don't think there's an actual configure check for the lz4 binary? Looks like
>> a static assignment in src/Makefile.global.in to me.
> Oh. That seems kind of dumb.
It looks to me like somebody figured it didn't need any more support
than gzip/bzip2, which is wrong on a couple of grounds:
* hardly any modern platforms lack those, unlike lz4
* we don't invoke either one of them during testing, only when
you explicitly ask to make a compressed tarball
I think adding an explicit PGAC_PATH_PROGS would be worth the cycles.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2022-02-12 23:00:03 | pgsql: Fix skip-empty-xacts with sequences in test_decoding |
| Previous Message | Robert Haas | 2022-02-12 22:10:32 | Re: pgsql: Add suport for server-side LZ4 base backup compression. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-02-12 22:26:25 | Re: Adding CI to our tree |
| Previous Message | Robert Haas | 2022-02-12 22:10:32 | Re: pgsql: Add suport for server-side LZ4 base backup compression. |