Re: pg_upgrade should truncate/remove its logs before running

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Julien Rouhaud <rjuju123(at)gmail(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pg_upgrade should truncate/remove its logs before running
Date: 2022-02-06 06:11:44
Message-ID: Yf9moK14gjWedzzo@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Sun, Feb 06, 2022 at 02:03:44PM +0800, Julien Rouhaud wrote:
> I didn't follow that thread closely, but if having the latest buildfarm client
> version installed is a hard requirement this will likely be a problem. First,
> there was no email to warn buildfarm owners that a new version is available,
> and even if there was I doubt that every owner would have updated it since.
> Especially since this is the lunar new year period, so at least 2 buildfarm
> owners (me included) are on holidays since last week.

The buildfarm will still be able to work as it did so that's not a
hard requirement per-se. The only thing changing is that we would not
find the logs in the event of a failure in the tests of pg_upgrade,
and the buildfarm client is coded to never fail if it does not see
logs in some of the paths it looks at, it just holds the full history
of the paths we have used across the ages.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-02-06 06:20:07 Re: Windows now has fdatasync()
Previous Message Bharath Rupireddy 2022-02-06 06:07:57 Re: Unclear problem reports