| From: | Michael Paquier <michael(at)paquier(dot)xyz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Subject: | Re: pgsql: Support "postgres -C" with runtime-computed GUCs |
| Date: | 2021-09-17 00:44:57 |
| Message-ID: | YUPlCVfPi1urH/iN@paquier.xyz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Fri, Sep 17, 2021 at 08:08:44AM +0900, Michael Paquier wrote:
> I am not completely sure what's going on here yet, so I'll just switch
> the test to be skipped when Msys is involved for now. That should be
> enough to bring back those machines to green.
So, after drinking down a coffee, I have remembered the difference
between the Msys and native perls when it comes to IPC::Run:
- Msys perl generates \r\n.
- Native perl generates \n.
We have already a couple of places where we filter that out, like
PostgresNode::psql or slurp_file. But we are missing some spots
before calling like() for outputs generated by IPC::Run. I have
tracked all those places with the attached, and I think that this
should take care of the failure seen here while preventing future
problems.
Any thoughts?
--
Michael
| Attachment | Content-Type | Size |
|---|---|---|
| fix-tap-msys-crlf.patch | text/plain | 2.9 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2021-09-17 01:03:05 | Re: pgsql: Support "postgres -C" with runtime-computed GUCs |
| Previous Message | Michael Paquier | 2021-09-17 00:14:15 | pgsql: Disable test for postgres -C on Msys |