From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
---|---|
To: | Michael Paquier <michael(at)paquier(dot)xyz> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-committers(at)lists(dot)postgresql(dot)org, Andrew Dunstan <andrew(at)dunslane(dot)net> |
Subject: | Re: pgsql: Support "postgres -C" with runtime-computed GUCs |
Date: | 2021-09-17 01:03:05 |
Message-ID: | 202109170103.qbjmwwvokbfl@alvherre.pgsql |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On 2021-Sep-17, Michael Paquier wrote:
> On Fri, Sep 17, 2021 at 08:08:44AM +0900, Michael Paquier wrote:
> > I am not completely sure what's going on here yet, so I'll just switch
> > the test to be skipped when Msys is involved for now. That should be
> > enough to bring back those machines to green.
>
> So, after drinking down a coffee, I have remembered the difference
> between the Msys and native perls when it comes to IPC::Run:
> - Msys perl generates \r\n.
> - Native perl generates \n.
Yeah, we've been here before -- see 015061690c65 and the commits
referenced there.
> We have already a couple of places where we filter that out, like
> PostgresNode::psql or slurp_file. But we are missing some spots
> before calling like() for outputs generated by IPC::Run. I have
> tracked all those places with the attached, and I think that this
> should take care of the failure seen here while preventing future
> problems.
Looks reasonable to me.
--
Álvaro Herrera 39°49'30"S 73°17'W — https://www.EnterpriseDB.com/
"¿Cómo puedes confiar en algo que pagas y que no ves,
y no confiar en algo que te dan y te lo muestran?" (Germán Poo)
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2021-09-17 06:53:48 | pgsql: Clarify some errors in pg_receivewal when closing WAL segments |
Previous Message | Michael Paquier | 2021-09-17 00:44:57 | Re: pgsql: Support "postgres -C" with runtime-computed GUCs |