Re: Small issues with CREATE TABLE COMPRESSION

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Jacob Champion <pchampion(at)vmware(dot)com>
Subject: Re: Small issues with CREATE TABLE COMPRESSION
Date: 2021-05-06 12:04:57
Message-ID: YJPbaYkIWeSbNF65@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, May 06, 2021 at 05:01:23PM +0530, Dilip Kumar wrote:
> I noticed that the error code for invalid compression method is not
> perfect, basically when we pass the invalid compression method during
> CREATE/ALTER table that time we give
> ERRCODE_FEATURE_NOT_SUPPORTED. I think the correct error code is
> ERRCODE_INVALID_PARAMETER_VALUE. I have attached a patch to fix this.

Yeah, I agree that this is an improvement, so let's fix this.
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2021-05-06 12:12:37 Re: Small issues with CREATE TABLE COMPRESSION
Previous Message Greg Nancarrow 2021-05-06 11:53:32 Re: [bug?] Missed parallel safety checks, and wrong parallel safety