| From: | Dilip Kumar <dilipbalaut(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Jacob Champion <pchampion(at)vmware(dot)com> |
| Subject: | Re: Small issues with CREATE TABLE COMPRESSION |
| Date: | 2021-05-06 11:31:23 |
| Message-ID: | CAFiTN-vH84fE-8C4zGZw4v0Wyh4Y2v=5JWg2fGE5+LPaDvz1GQ@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, May 6, 2021 at 10:45 AM Dilip Kumar <dilipbalaut(at)gmail(dot)com> wrote:
I noticed that the error code for invalid compression method is not
perfect, basically when we pass the invalid compression method during
CREATE/ALTER table that time we give
ERRCODE_FEATURE_NOT_SUPPORTED. I think the correct error code is
ERRCODE_INVALID_PARAMETER_VALUE. I have attached a patch to fix this.
I thought of starting a new thread first but then I thought the
subject of this thread is quite generic and this is a fairly small fix
so we can use the same thread.
--
Regards,
Dilip Kumar
EnterpriseDB: http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-thinko-in-invalid-compression-error-code.patch | text/x-patch | 899 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-05-06 11:39:40 | Re: RFC: Detailed reorder buffer stats dumps |
| Previous Message | Pavel Luzanov | 2021-05-06 11:22:56 | Re: ALTER TABLE .. DETACH PARTITION CONCURRENTLY |