Re: Disallow SSL compression?

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: Daniel Gustafsson <daniel(at)yesql(dot)se>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Disallow SSL compression?
Date: 2021-03-04 10:59:47
Message-ID: YEC9o+1PBDNlmAhG@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Mar 03, 2021 at 03:14:01PM +0100, Peter Eisentraut wrote:
> Per your other thread, you should also remove the environment variable.
>
> In postgres_fdw, I think commenting it out is not the right change. The
> other commented out values are still valid settings but are omitted from the
> test for other reasons. It's not entirely all clear, but we don't have to
> keep obsolete stuff in there forever.

Agreed on both points. Also, it seems a bit weird to keep around
pg_stat_ssl.compression while we know that it will always be false.
Wouldn't it be better to get rid of that in PgBackendSSLStatus and
pg_stat_ssl then?
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Ibrar Ahmed 2021-03-04 11:02:26 Re: [POC] Fast COPY FROM command for the table with foreign partitions
Previous Message Ibrar Ahmed 2021-03-04 10:53:34 Re: Allow matching whole DN from a client certificate