| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Disallow SSL compression? |
| Date: | 2021-03-04 22:54:17 |
| Message-ID: | 3B1910F8-92BD-4979-B333-09FBFDE627F3@yesql.se |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 4 Mar 2021, at 11:59, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Wed, Mar 03, 2021 at 03:14:01PM +0100, Peter Eisentraut wrote:
>> Per your other thread, you should also remove the environment variable.
>>
>> In postgres_fdw, I think commenting it out is not the right change. The
>> other commented out values are still valid settings but are omitted from the
>> test for other reasons. It's not entirely all clear, but we don't have to
>> keep obsolete stuff in there forever.
>
> Agreed on both points. Also, it seems a bit weird to keep around
> pg_stat_ssl.compression while we know that it will always be false.
> Wouldn't it be better to get rid of that in PgBackendSSLStatus and
> pg_stat_ssl then?
Fixed in the v4 posted just now, although I opted for keeping the column in
pg_stat_ssl for backwards compatibility with a doc note.
--
Daniel Gustafsson https://vmware.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2021-03-04 23:03:43 | Re: libpq debug log |
| Previous Message | Daniel Gustafsson | 2021-03-04 22:52:56 | Re: Disallow SSL compression? |