Re: Use get_call_result_type() more widely

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Use get_call_result_type() more widely
Date: 2022-12-20 07:38:59
Message-ID: Y6Fmk2Y5d07MbdQx@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Dec 19, 2022 at 07:41:27PM +0530, Bharath Rupireddy wrote:
> I agree with the bucketization. Please see the attached patches. 0001
> - gets rid of explicit tuple desc creation using
> get_call_result_type() for functions thought to be not-so-frequently
> called.

It looks like I am OK with the code paths updated here, which refer to
none of the "critical" function paths.

> 0002 - gets rid of an unnecessary call to BlessTupleDesc()
> after get_call_result_type().

Hmm. I am not sure whether this is right, actually..
--
Michael

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2022-12-20 07:57:41 Re: Add LSN along with offset to error messages reported for WAL file read/write/validate header failures
Previous Message Michael Paquier 2022-12-20 07:32:36 Re: Use get_call_result_type() more widely