| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Use get_call_result_type() more widely |
| Date: | 2022-12-20 08:11:39 |
| Message-ID: | 1125757.1671523899@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Mon, Dec 19, 2022 at 07:41:27PM +0530, Bharath Rupireddy wrote:
>> 0002 - gets rid of an unnecessary call to BlessTupleDesc()
>> after get_call_result_type().
> Hmm. I am not sure whether this is right, actually..
Hmm ... at least one of the paths through internal_get_result_type
is intentionally blessing the result tupdesc:
if (tupdesc->tdtypeid == RECORDOID &&
tupdesc->tdtypmod < 0)
assign_record_type_typmod(tupdesc);
but it's not clear if they all do, and the comments certainly
aren't promising it.
I'd be in favor of making this a documented API promise,
but it isn't that right now.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2022-12-20 08:19:25 | Re: slab allocator performance issues |
| Previous Message | Magnus Hagander | 2022-12-20 07:57:41 | Re: Add LSN along with offset to error messages reported for WAL file read/write/validate header failures |