Re: Refactoring HMAC in the core code

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Daniel Gustafsson <daniel(at)yesql(dot)se>
Subject: Re: Refactoring HMAC in the core code
Date: 2020-12-18 06:46:42
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Fri, Dec 18, 2020 at 08:41:01AM +0900, Michael Paquier wrote:
> Knowing that we are in a period of vacations for a lot of people, and
> that this is a sensitive area of the code that involves
> authentication, I think that it is better to let this thread brew
> longer and get more eyes to look at it. As this also concerns
> external SSL libraries like libnss, making sure that the APIs have a
> shape flexible enough would be good. Based on my own checks with
> OpenSSL and libnss, I think that's more than enough. But let's be
> sure.

FWIW, I got my eyes on this stuff again today, and please find
attached a v2, where I have fixed a certain number of issues:
- Fixed a memory leak with the shrink buffer in the fallback
- Fixed a couple of incorrect comments.
- The logic around the resowner was a bit busted with OpenSSL <=
1.0.2. So I haev reorganized the code a bit.

This has been tested on Windows and Linux across all the versions of
OpenSSL we support on HEAD. I am also attaching a small module called
hmacfuncs that I used as a way to validate this patch across all the
versions of OpenSSL and the fallback implementation. As a reference,
this matches with the results from Wikipedia here:

Attachment Content-Type Size
v2-0001-Refactor-HMAC-implementations.patch text/x-diff 38.0 KB
hmacfuncs.tar.gz application/gzip 1.6 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2020-12-18 06:58:08 Re: allow to \dtS+ pg_toast.*
Previous Message Wang, Shenhao 2020-12-18 06:22:36 pgbench failed when -f option contains a char '@'