pgbench failed when -f option contains a char '@'

From: "Wang, Shenhao" <wangsh(dot)fnst(at)cn(dot)fujitsu(dot)com>
To: "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: pgbench failed when -f option contains a char '@'
Date: 2020-12-18 06:22:36
Message-ID: 1c4e81550d214741827a03292222db8d@G08CNEXMBPEKD06.g08.fujitsu.local
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi, hackers

pgbench use -f filename[(at)weight] to receive a sql script file with a weight,
but if I create a file contains char'@', like a(at)2(dot)sql, specify this file without weigth,
pgbench will failed with error:
pgbench: fatal: invalid weight specification: @2.sql

This action may be unfriendly, because the char '@' is a valid character on Linux
and Windows.

I have created a patch to modify this action. The patch is attached.

Thoughts?

Regards
Shenhao Wang

Attachment Content-Type Size
0001-Improve-pgbench-when-f-option-contain-char-in-filepa.patch application/octet-stream 2.9 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2020-12-18 06:46:42 Re: Refactoring HMAC in the core code
Previous Message Pavel Stehule 2020-12-18 05:54:30 Re: [HACKERS] [PATCH] Generic type subscripting