Re: Minor documentation error regarding streaming replication protocol

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Jeff Davis <pgsql(at)j-davis(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Brar Piening <brar(at)gmx(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Minor documentation error regarding streaming replication protocol
Date: 2020-12-16 00:30:36
Message-ID: X9lVLGRuG0hTHrVo@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Dec 15, 2020 at 12:54:51PM -0800, Andres Freund wrote:
> Minor nit: I'd put this into common/string.[ch], besides
> pg_clean_ascii(). Probably renaming it to pg_is_ascii().

Yeah. There is already one pg_is_ascii_string() in saslprep.c,
is_all_ascii() in collationcmds.c and string_is_ascii() in
pgp-pgsql.c. I don't think we need a fourth copy of the same logic,
even if it is dead simple.
--
Michael

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2020-12-16 00:36:22 Re: Proposed patch for key managment
Previous Message Michael Paquier 2020-12-16 00:27:53 Re: REINDEX backend filtering