| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Jeff Davis <pgsql(at)j-davis(dot)com> |
| Cc: | Bruce Momjian <bruce(at)momjian(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, Brar Piening <brar(at)gmx(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Minor documentation error regarding streaming replication protocol |
| Date: | 2020-12-15 20:54:51 |
| Message-ID: | 20201215205451.jhfzhkmhqqutc4vi@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2020-12-15 01:22:44 -0800, Jeff Davis wrote:
> Attached a simple patch that enforces an all-ASCII restore point name
> rather than documenting the possibility of non-ASCII text.
+1
> diff --git a/src/backend/access/transam/xlogfuncs.c b/src/backend/access/transam/xlogfuncs.c
> index 290658b22c..48daed56f6 100644
> --- a/src/backend/access/transam/xlogfuncs.c
> +++ b/src/backend/access/transam/xlogfuncs.c
> @@ -44,6 +44,8 @@
> static StringInfo label_file;
> static StringInfo tblspc_map_file;
>
> +static bool is_all_ascii(const char *str);
Minor nit: I'd put this into common/string.[ch], besides
pg_clean_ascii(). Probably renaming it to pg_is_ascii().
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2020-12-15 21:02:12 | Re: Proposed patch for key managment |
| Previous Message | Tom Lane | 2020-12-15 20:17:30 | Re: Rethinking plpgsql's assignment implementation |