RE: Simplify code building the LR conflict messages

From: "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>
To: 'shveta malik' <shveta(dot)malik(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Peter Smith <smithpb2250(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>
Subject: RE: Simplify code building the LR conflict messages
Date: 2026-01-21 02:22:02
Message-ID: TY7PR01MB145540FBD844FCFD930745CC4F596A@TY7PR01MB14554.jpnprd01.prod.outlook.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Dear hackers,

Thanks for the comment. I fixed a whitespace issue. I attach only 0001 to focus on it.
Also, Hou Zhijie gave a comment to improve the code comment (maybe it's under
moderation). His point is that get_tuple_ function can also append the description
for each attribute and append_tuple_value_detail() can handle lists of them.
I've updated based on this, taking into account the lack of permissions.

How do you think?

Best regards,
Hayato Kuroda
FUJITSU LIMITED

Attachment Content-Type Size
v7-0001-Fix-errdetail-for-logical-replication-conflict.patch application/octet-stream 36.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Chao Li 2026-01-21 02:53:43 Re: docs: clarify ALTER TABLE behavior on partitioned tables
Previous Message David G. Johnston 2026-01-21 01:09:25 Re: docs: clarify ALTER TABLE behavior on partitioned tables