| From: | shveta malik <shveta(dot)malik(at)gmail(dot)com> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Peter Smith <smithpb2250(at)gmail(dot)com>, "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Subject: | Re: Simplify code building the LR conflict messages |
| Date: | 2026-01-21 03:50:07 |
| Message-ID: | CAJpy0uCfh7gxSQryfHqhdjrrxZ2Ki7T_us9=RNiTiNt3ueCN4w@mail.gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Jan 21, 2026 at 7:52 AM Hayato Kuroda (Fujitsu)
<kuroda(dot)hayato(at)fujitsu(dot)com> wrote:
>
> Dear hackers,
>
> Thanks for the comment. I fixed a whitespace issue. I attach only 0001 to focus on it.
> Also, Hou Zhijie gave a comment to improve the code comment (maybe it's under
> moderation). His point is that get_tuple_ function can also append the description
> for each attribute and append_tuple_value_detail() can handle lists of them.
> I've updated based on this, taking into account the lack of permissions.
>
> How do you think?
>
The function re-structuring looks good. No issues observed in my local
testing. Thus the patch LGTM.
thanks
Shveta
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Chao Li | 2026-01-21 03:55:27 | tablecmds: reject CLUSTER ON for partitioned tables earlier |
| Previous Message | Henson Choi | 2026-01-21 03:27:15 | Re: Row pattern recognition |