| From: | "Zhijie Hou (Fujitsu)" <houzj(dot)fnst(at)fujitsu(dot)com> |
|---|---|
| To: | Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Mihail Nikalayeu <mihailnikalayeu(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, vignesh C <vignesh21(at)gmail(dot)com>, "ashutosh(dot)bapat(dot)oss(at)gmail(dot)com" <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com> |
| Subject: | RE: Crashes on a partition whose concurrent detach never finished |
| Date: | 2026-09-11 07:22:16 |
| Message-ID: | TY4PR01MB177181B0B5A70FB78038B76C394BE2@TY4PR01MB17718.jpnprd01.prod.outlook.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On Friday, September 11, 2026 2:01 PM Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> wrote:
>
> Thanks for sharing the patch. It looks good to me. I’ve updated the attached
> patch accordingly.
The fix looks mostly good to me. The only nit is that we could avoid introducing
a new Boolean flag by writing it like this:
RelationBuildPublicationDesc()
..
if (relation->rd_rel->relispartition)
ancestors = get_partition_ancestors(relid);
if (ancestors)
{
Oid last_ancestor_relid;
last_ancestor_relid = llast_oid(ancestors);
...
Best Regards,
Zhijie Hou
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2026-09-11 07:22:36 | Re: Review items for EXCEPT TABLE publication |
| Previous Message | Srinath Reddy Sadipiralla | 2026-09-11 07:18:20 | Re: SQL/JSON: JSON_TRANSFORM (SQL standard, subclause 6.44) |