Re: Crashes on a partition whose concurrent detach never finished

On Fri, Sep 11, 2026 at 12:52 PM Zhijie Hou (Fujitsu)
<houzj(dot)fnst(at)fujitsu(dot)com> wrote:
>
> Hi,
>
> On Friday, September 11, 2026 2:01 PM Nisha Moond <nisha(dot)moond412(at)gmail(dot)com> wrote:
> >
> > Thanks for sharing the patch. It looks good to me. I’ve updated the attached
> > patch accordingly.
>
> The fix looks mostly good to me. The only nit is that we could avoid introducing
> a new Boolean flag by writing it like this:
>
> RelationBuildPublicationDesc()
> ..
> if (relation->rd_rel->relispartition)
> ancestors = get_partition_ancestors(relid);
>
> if (ancestors)
> {
> Oid last_ancestor_relid;
>
> last_ancestor_relid = llast_oid(ancestors);
> ...
>

Okay, agree. Changed as suggested.

Also addressed Shveta’s comments from [1] and Amit’s off-list suggestions.

Please find the updated patch attached.

[1] https://www.postgresql.org/message-id/CAJpy0uD9TLWsnLXBk4Wz7ydDc5%3DOh%2BFamgqKRHd64RcG1h-s8g%40mail.gmail.com

--
Thanks,
Nisha