| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
| Cc: | Hiroshi Inoue <Inoue(at)tpf(dot)co(dot)jp>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [ODBC] MD5 support for ODBC |
| Date: | 2001-11-12 19:24:50 |
| Message-ID: | Pine.LNX.4.30.0111121934470.640-100000@peter.localdomain |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-odbc pgsql-patches |
Bruce Momjian writes:
> ! all: check_md5 SUBSYS.o
> !
> ! check_md5:
> ! @cmp -s md5.c ../../interfaces/odbc/md5.c || \
> ! (echo "src/interfaces/odbc/md5.c doesn't match src/backend/libpq/md5.c" && \
> ! exit 1)
Nope, this doesn't work. The source directory is not necessarily the
current directory.
I don't think it's particularly useful to put checks of static source
files in the build path. There are quite a number of places that need to
be synchronized manually and there is no check anywhere. It would
probably have been better to have one master copy of the file and symlink
it to whereever else it is needed. (See libpq Makefile for several
examples.)
--
Peter Eisentraut peter_e(at)gmx(dot)net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simeo Reig | 2001-11-12 20:43:02 | Re: Last inserted id |
| Previous Message | Bruce Momjian | 2001-11-12 19:23:23 | Re: [ODBC] MD5 support for ODBC |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Brent Verner | 2001-11-12 19:38:55 | Re: ALTER TABLE RENAME fix |
| Previous Message | Peter Eisentraut | 2001-11-12 19:23:51 | Re: stupid patch of pg_dumplo |