Re: [ODBC] MD5 support for ODBC

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Hiroshi Inoue <Inoue(at)tpf(dot)co(dot)jp>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [ODBC] MD5 support for ODBC
Date: 2001-11-12 01:49:57
Message-ID: 200111120149.fAC1nvR28663@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-odbc pgsql-patches

> Bruce Momjian wrote:
> >
> > The attached patch should add MD5 support to ODBC. I don't have ODBC
> > here so I would appreciate if someone would test it and let me know. I
> > am not considering applying the patch to CVS.
>
> I checked it under Windows and it worked well.
> I already committed the interfaces/odbc part.

OK, great. I am surprised it worked the first time. I didn't test it
here, and I am know more for my persistance than skill. :-)

I have applied the rest of the patch. It adds a check to the
backend/libpq Makefile and aborts if the two C md5.c files are not
identical.

There are two copies of md5.c because odbc has to be compile-able on its
own, and md5.c is also used by the backend and libpq. With this check,
the two files will remain in sync because it will not even compile if
they aren't.

Also, odbc/md5.h has copies of certain definitions that normally appear
in include/c.h. Because md5.c must compile alone in the odbc directory,
I needed those defines pulled out and added into odbc. I will document
that these defines also appear in odbc/md5.h.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 853-3000
+ If your life is a hard drive, | 830 Blythe Avenue
+ Christ can be your backup. | Drexel Hill, Pennsylvania 19026

Attachment Content-Type Size
unknown_filename text/plain 1.6 KB

In response to

Responses

Browse pgsql-odbc by date

  From Date Subject
Next Message Dave Page 2001-11-12 08:23:08 Re: Last inserted id
Previous Message Hiroshi Inoue 2001-11-12 01:28:18 Re: Large Objects; ODBC & Transactions

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2001-11-12 02:36:47 Re: Patch for Makefile race against current cvs
Previous Message Hiroshi Inoue 2001-11-12 01:02:05 Re: [ODBC] MD5 support for ODBC