Re: pgsql/src/bin/pg_ctl pg_ctl.sh

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Bruce Momjian - CVS <momjian(at)hub(dot)org>
Cc: <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql/src/bin/pg_ctl pg_ctl.sh
Date: 2001-07-11 19:20:13
Message-ID: Pine.LNX.4.30.0107112118500.679-100000@peter.localdomain
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

I wrote:

> > Move export PGDATA to the proper place.
>
> This is completely broken. The old place was right.

Correction: The new place also seems to be okay, but 'export VAR=stuff'
is not portable, You need to split it into two commands.

> > Quote some variable substitutions.
>
> You don't need to quote the argument to 'case'. Please don't do that, it
> makes things less readable.

Also, you don't need to quote the right side of

FOO=$BAR

--
Peter Eisentraut peter_e(at)gmx(dot)net http://funkturm.homeip.net/~peter

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2001-07-11 19:35:54 Re: pgsql/src/bin/pg_ctl pg_ctl.sh
Previous Message Bruce Momjian 2001-07-11 19:17:03 Re: pgsql/src/bin/pg_ctl pg_ctl.sh